Sulley
/
Ultron
1
0
Fork 0
Code Issues 15 Pull Requests 1 Projects Releases Wiki Activity

review/core-app #14

Merged
Sulley merged 4 commits from review/core-app into master 2022-01-06 17:28:22 +01:00
Conversation 0 Commits 4 Files Changed 11 +57 -14
Fred commented 2022-01-06 16:52:02 +01:00
Collaborator
Copy Link

Yop @Sulley

J'ai créé une application core pour y bouger tout ce qui se trouvait encore au niveau de la configuration (notamment, les vues de login, logout, home et search).

J'ai ajouté deux tests pour vérifier

1/ que la page "home" renvoyait vers la page de login (ou en tout cas, que l'utilisateur non connecté était redirigé)
2/ que la page "home" était bien accessible après connexion d'un utilisateur (non admin, non staff).

Tu veux bien la merger siteuplé ? 😙

Yop @Sulley J'ai créé une application `core` pour y bouger tout ce qui se trouvait encore au niveau de la configuration (notamment, les vues de login, logout, home et search). J'ai ajouté deux tests pour vérifier 1/ que la page "home" renvoyait vers la page de login (ou en tout cas, que l'utilisateur non connecté était redirigé) 2/ que la page "home" était bien accessible après connexion d'un utilisateur (non admin, non staff). Tu veux bien la merger siteuplé ? 😙
Fred added the
enhancement
 label 2022-01-06 16:52:02 +01:00
Sulley was assigned by Fred 2022-01-06 16:52:02 +01:00
Fred added 3 commits 2022-01-06 16:52:03 +01:00
3fac4319a7 Create 'core' app 
Move 'config.views' inside this new application.
The objective will be to decouple the configuration from core files.
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is failing Details
292c97c64f Make tests pass on home page
Fred added 1 commit 2022-01-06 16:53:08 +01:00
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is passing Details
62fed584b4 There is still a bug with whitenoise and static files storage
Sulley merged commit f97a8f6898 into master 2022-01-06 17:28:22 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
improvement

improve functionality already there

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
improvement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Sulley
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Sulley/Ultron#14
No description provided.
Delete Branch "review/core-app"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?