Ajouter 'articles/dev/merge-requests-check-list.md'

articles/dev/merge-requests-check-list.md

@@ -0,0 +1,35 @@
+http://dev.howtommy.net/?d=2019/09/10/06/00/00-merge-request-la-checklist
+
+------------------------------- MERGE REQUEST CHECKLIST -------------------------------
+
+Date :
+Dev name :
+Reviewer name :
+Branch :
+
+MANDATORY
+☐ The PO validated (solution + go for merge)
+☐ The target branch was merged in the current branch
+☐ It compiles
+☐ No code / lint warnings or errors
+☐ It was tested on all target devices
+☐ The wiki documentation was updated
+☐ If the environment changed (global packages, .env file, …), the CI was updated and the team was warned by email
+
+OPTIONAL (code reminders)
+☐ PRODUCT : Every complicated choices are explained somewhere (documentation, specifications, comments, etc.)
+☐ CODE QUALITY : No //todo or useless logs
+☐ CODE QUALITY : No refactoring planned for later
+☐ CODE QUALITY : The code is easy to read
+☐ COMPONENTS : OnPush on each component
+☐ COMPONENTS : Smart/dumb pattern used
+☐ PERFORMANCES : takeUntil($onDestroy) pattern applied on subscriptions
+☐ PERFORMANCES : the app is fluid to use, no performances drop
+☐ ROUTING : the pages routing is consistent and hierarchical
+☐ SCSS : Each component is responsible of its look (not its parents)
+☐ SCSS : No size calculations in typescript (only CSS for sizes)
+☐ TESTS : tested with 360/375/414/768px of width
+☐ TESTS : Unit tests written / updated
+☐ ACCESSIBILITY : It works with bigger fonts
+
+------------------------------- /MERGE REQUEST CHECKLIST -------------------------------